-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch fs-extra to fix images on arm64 #318
Conversation
3098a70
to
d551401
Compare
I did. sadly, it still does not work. Here are two screen shots from my snap build (bad) and dennisameling build (good): |
I have never built a snap before. Maybe I made a mistake? Here is what I did:
|
Hmm, that looks right. I'll have a poke about and check the patch was applied properly |
d551401
to
43c7f07
Compare
@CarstenKochElsdorf I just updated this slightly, I don't think the patch was applied properly. Can you try a pull and rebuild?
|
Working now. |
Nice, should land in |
Fixes #279
Adds a patch to the build which reportedly fixes an issue rendering images on arm64.
@CarstenKochElsdorf perhaps you could build & test?